Adds Redis Memory extension class - #6743
Conversation
Eric Zhu (ekzhu)
left a comment
Eric Zhu (ekzhu)
left a comment
There was a problem hiding this comment.
Thanks for the PR. A couple of things:
- Let's use the module path
autogen_ext.memory.redisfor the new module. - Add API doc to
RedisMemorywith examples of usage. Make sure the code blocks are checked by pyright, the CI checks the formatting and types of API docs. Seepython/README.mdfor information on checks. Many users use the API Reference directly. - In the usage guide notebook, can you simplify the setup instructions for the redis example. The example should just refer to the API doc using reference:
{py:class}`~autogen_ext.memory.redisvl.RedisMemory`
f309dd0 to
dabb01c
Compare
|
Eric Zhu (@ekzhu) thanks for the review, it's really appreciated. |
|
@microsoft-github-policy-service agree company="Redis" |
…k/autogen into feature/add-redis-memory
…k/autogen into feature/add-redis-memory
|
Tyler Hutcherson (@tylerhutcherson) if you want to follow along with this PR. |
|
Looks like there are a lot of test failures. |
Hey Eric Zhu (@ekzhu) stepping in for Justin Cechmanek (@justin-cechmanek) to help get us over the finish line here. We are looking into the failures. Looks like part of the issue was a uv.lock update. Can you try rerunning them again? We will dig to see what parts of our code and tests touch these suites. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6743 +/- ##
==========================================
- Coverage 79.92% 79.91% -0.01%
==========================================
Files 233 235 +2
Lines 18108 18172 +64
==========================================
+ Hits 14473 14523 +50
- Misses 3635 3649 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 participants
Why are these changes needed?
This PR adds the RedisMemory class to allow for developers to use Redis vector search for agent memory. Redis vector db offers a persistent store and the ability to semantically search for relevant memories.
Related issue number
None
Checks